Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32653 )
Change subject: soc/amd/stoneyridge: Move LPC support to common
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/32653/6/src/soc/amd/stoneyridge/southbridge....
File src/soc/amd/stoneyridge/southbridge.c:
https://review.coreboot.org/#/c/32653/6/src/soc/amd/stoneyridge/southbridge....
PS6, Line 230: STONEYRIDGE_LEGACY_FREE
I don't disagree with your thinking, but this source is simply relocated from line 560. […]
I'm fine with fixing this in a follow-on commit. Isn't the logic here backwards though?
If the system is legacy free, why do we enable LPC decode if there's no SIO on the LPC?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32653
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d7175b8642bb17533bb2287b3e3ee3d52e85a75
Gerrit-Change-Number: 32653
Gerrit-PatchSet: 6
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 06 Jun 2019 18:48:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Comment-In-Reply-To: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-MessageType: comment