Patch set 6:Code-Review +2

View Change

1 comment:

• File src/soc/amd/stoneyridge/southbridge.c:

  • Patch Set #6, Line 230: STONEYRIDGE_LEGACY_FREE

    I don't disagree with your thinking, but this source is simply relocated from line 560. […]

    I'm fine with fixing this in a follow-on commit. Isn't the logic here backwards though?

    If the system is legacy free, why do we enable LPC decode if there's no SIO on the LPC?

To view, visit change 32653. To unsubscribe, or for help writing mail filters, visit settings.