Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42547 )
Change subject: cpu/intel/model_206ax: Add overclocking support ......................................................................
Patch Set 1: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/42547/1/src/cpu/intel/model_206ax/m... File src/cpu/intel/model_206ax/model_206ax_init.c:
https://review.coreboot.org/c/coreboot/+/42547/1/src/cpu/intel/model_206ax/m... PS1, Line 443: xe_init what's XE? Extreme?
https://review.coreboot.org/c/coreboot/+/42547/1/src/cpu/intel/model_206ax/m... PS1, Line 449: printk(BIOS_DEBUG, "XE: not overriding Turbo Ratio limits\n"); since the default is disabled, only print this text when it has been enabled in Kconfig?
https://review.coreboot.org/c/coreboot/+/42547/1/src/cpu/intel/model_206ax/m... PS1, Line 459: 0x206a3 huh, that cpuid isn't in the cpu_table list?