21 Oct
2020
21 Oct
'20
3:57 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46603 )
Change subject: sec/intel/txt: Split MTRR setup ASM code into a macro ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46603/1/src/security/intel/txt/gets... File src/security/intel/txt/getsec_enteraccs.S:
https://review.coreboot.org/c/coreboot/+/46603/1/src/security/intel/txt/gets... PS1, Line 7: #include "getsec_mtrr_setup.S"
It should probably be called getsec_mtrr_setup.inc then.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/46603
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2f5e82f57b458ca1637790ddc1ddc14bba68ac49
Gerrit-Change-Number: 46603
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 21 Oct 2020 12:57:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Gerrit-MessageType: comment