[coreboot-gerrit] Change in ...coreboot[master]: src/soc/intel/cnl/chip.h: Fix preprocessor condition

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31095 )

Change subject: src/soc/intel/cnl/chip.h: Fix preprocessor condition
......................................................................

Patch Set 4:
> Patch Set 4: Code-Review+1
> > Patch Set 4:
> > > Patch Set 4: Code-Review-1
> > >
> > > Kindly hold this CL, till the time submitter of original CL come and share his view. 
> > > -1 just to block this CL from merge else no issue
> >
> > Ack, I will add them as reviewer.
>
> At this point we can use this change but I think we should have different Kconfig options for all SOC.

I agree. If CNL, CFL and WHL are similar it would be a good idea to make a common Kconfig option for all three, and make SOC_INTEL_CANNONLAKE CNL-specific.