[coreboot-gerrit] Change in coreboot[master]: mb/clevo/cml-u: Move mainboard/gpio.h to variant/gpio.h

[Michael Niewöhner (Code Review)]

Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48296 )

Change subject: mb/clevo/cml-u: Move mainboard/gpio.h to variant/gpio.h
......................................................................

mb/clevo/cml-u: Move mainboard/gpio.h to variant/gpio.h

Move mainboard/gpio.h to variant/gpio.h and rename its methods to make
clear that these methods are implemented on variant level.

Change-Id: I1ae9b54ed683000f65323b11747ce3280a1c7f2a
Signed-off-by: Felix Singer 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/48296
Reviewed-by: Michael Niewöhner 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/clevo/cml-u/bootblock.c
D src/mainboard/clevo/cml-u/include/mainboard/gpio.h
A src/mainboard/clevo/cml-u/include/variant/gpio.h
M src/mainboard/clevo/cml-u/ramstage.c
M src/mainboard/clevo/cml-u/variants/l140cu/gpio.c
M src/mainboard/clevo/cml-u/variants/l140cu/gpio_early.c
6 files changed, 17 insertions(+), 17 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Michael Niewöhner: Looks good to me, approved

diff --git a/src/mainboard/clevo/cml-u/bootblock.c b/src/mainboard/clevo/cml-u/bootblock.c
index d75158c..389a7a9 100644
--- a/src/mainboard/clevo/cml-u/bootblock.c
+++ b/src/mainboard/clevo/cml-u/bootblock.c
@@ -2,9 +2,9 @@

#include <bootblock_common.h>
 #include <gpio.h>
-#include <mainboard/gpio.h>
+#include <variant/gpio.h>

void bootblock_mainboard_init(void)
 {
-	mainboard_configure_early_gpios();
+	variant_configure_early_gpios();
 }
diff --git a/src/mainboard/clevo/cml-u/include/mainboard/gpio.h b/src/mainboard/clevo/cml-u/include/mainboard/gpio.h
deleted file mode 100644
index c6393be..0000000
--- a/src/mainboard/clevo/cml-u/include/mainboard/gpio.h
+++ /dev/null
@@ -1,9 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-
-#ifndef MAINBOARD_GPIO_H
-#define MAINBOARD_GPIO_H
-
-void mainboard_configure_early_gpios(void);
-void mainboard_configure_gpios(void);
-
-#endif
diff --git a/src/mainboard/clevo/cml-u/include/variant/gpio.h b/src/mainboard/clevo/cml-u/include/variant/gpio.h
new file mode 100644
index 0000000..95d5762
--- /dev/null
+++ b/src/mainboard/clevo/cml-u/include/variant/gpio.h
@@ -0,0 +1,9 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+
+#ifndef VARIANT_GPIO_H
+#define VARIANT_GPIO_H
+
+void variant_configure_early_gpios(void);
+void variant_configure_gpios(void);
+
+#endif
diff --git a/src/mainboard/clevo/cml-u/ramstage.c b/src/mainboard/clevo/cml-u/ramstage.c
index 771c6aa..8196970 100644
--- a/src/mainboard/clevo/cml-u/ramstage.c
+++ b/src/mainboard/clevo/cml-u/ramstage.c
@@ -1,11 +1,11 @@
 /* SPDX-License-Identifier: GPL-2.0-only */

#include <device/device.h>
-#include <mainboard/gpio.h>
+#include <variant/gpio.h>

static void init_mainboard(void *chip_info)
 {
-	mainboard_configure_gpios();
+	variant_configure_gpios();
 }

struct chip_operations mainboard_ops = {
diff --git a/src/mainboard/clevo/cml-u/variants/l140cu/gpio.c b/src/mainboard/clevo/cml-u/variants/l140cu/gpio.c
index 475c2d5..d5744ef 100644
--- a/src/mainboard/clevo/cml-u/variants/l140cu/gpio.c
+++ b/src/mainboard/clevo/cml-u/variants/l140cu/gpio.c
@@ -1,8 +1,8 @@
 /* SPDX-License-Identifier: GPL-2.0-only */

-#include <mainboard/gpio.h>
 #include <soc/gpe.h>
 #include <soc/gpio.h>
+#include <variant/gpio.h>

/* Name format: <pad name> / <net/pin name in schematics> */
 static const struct pad_config gpio_table[] = {
@@ -237,7 +237,7 @@
    PAD_NC(GPP_H23, UP_20K),
 };

-void mainboard_configure_gpios(void)
+void variant_configure_gpios(void)
 {
    gpio_configure_pads(gpio_table, ARRAY_SIZE(gpio_table));
 }
diff --git a/src/mainboard/clevo/cml-u/variants/l140cu/gpio_early.c b/src/mainboard/clevo/cml-u/variants/l140cu/gpio_early.c
index 274efaf..3ea1c81 100644
--- a/src/mainboard/clevo/cml-u/variants/l140cu/gpio_early.c
+++ b/src/mainboard/clevo/cml-u/variants/l140cu/gpio_early.c
@@ -1,7 +1,7 @@
 /* SPDX-License-Identifier: GPL-2.0-only */

-#include <mainboard/gpio.h>
 #include <soc/gpio.h>
+#include <variant/gpio.h>

/* Name format: <pad name> / <net/pin name in schematics> */
 static const struct pad_config early_gpio_table[] = {
@@ -11,7 +11,7 @@
    PAD_NC(GPP_C23, UP_20K),
 };

-void mainboard_configure_early_gpios(void)
+void variant_configure_early_gpios(void)
 {
    gpio_configure_pads(early_gpio_table, ARRAY_SIZE(early_gpio_table));
 }