Attention is currently required from: Angel Pons.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35759 )
Change subject: [TESTME]nb/intel/pineview: Use regular udelay over hpet_udelay
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Almost a year later, I still haven't tested this. I suspect that regular udelay might be too imprecise for use in some raminit parts.
Me neither (and should before it's acceptable). Al other raminits seems fine with the tsc udelay so it's likely that this works fine.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35759
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I619e2f215f94858e53ac1369b2f6d995303aa3cf
Gerrit-Change-Number: 35759
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 12 Jan 2021 22:48:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment