Patrik Tesarik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40403 )
Change subject: mb/up/squared: Fix eMMC speed for UP2 with EDK2
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40403/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/40403/3//COMMIT_MSG@7
PS3, Line 7: src/mainboard: Make eMMC for UP2 with EDK2
looks like the verb "work" from my suggestion was omitted
@Angel, yes I forgot to add the additional word. Sorry.
@dMichał, I like your wording better. I think it's more precise to what the commit will affect if applied.
Thanks for both of your suggestions.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40403
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d53204d8a776efd560fbdea918f83e180813179
Gerrit-Change-Number: 40403
Gerrit-PatchSet: 4
Gerrit-Owner: Patrik Tesarik
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Comment-Date: Mon, 20 Apr 2020 08:07:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment