Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45448 )
Change subject: nb/intel/gm45: Add more DMIBAR/EPBAR registers ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45448/3/src/northbridge/intel/gm45/... File src/northbridge/intel/gm45/pcie.c:
https://review.coreboot.org/c/coreboot/+/45448/3/src/northbridge/intel/gm45/... PS3, Line 42: ;
Beside that it's ugly, I already see this commit: […]
I don't see that commit anywhere, I suppose it needs to be made? I however see CB:7683 which does the same as this patch, and also adds a comment.
Having the semicolon on the same line as the `while` statement does not seem to be very popular, anyway:
grep -r "while (.*);" src/ | grep -v "} *while" | grep -v "#define"
Compared to:
grep -r " ;"
Note: the whitespace is a literal tab character.