Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34630 )
Change subject: mb/intel/minnowmax: Add config for FSP_PACKAGE_DEFAULT
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34630/7/src/mainboard/intel/minnowm...
File src/mainboard/intel/minnowmax/Kconfig:
https://review.coreboot.org/c/coreboot/+/34630/7/src/mainboard/intel/minnowm...
PS7, Line 62: Configure defaults for the Intel FSP package
This does not seem to match the description of what it does. All it does is setting CONFIG_VGA_BIOS=y by default and always CONFIG_HAVE_FSP_BIN=y.
I don't really see a point in this symbol. Maybe drop it from all mainboard Kconfig files?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34630
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifb1a92287ad5beea6559db0cd4cf66eeb0f46f95
Gerrit-Change-Number: 34630
Gerrit-PatchSet: 7
Gerrit-Owner: Name of user not set #1002476
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Name of user not set #1002476
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 19 Aug 2019 16:39:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment