28 Feb
2020
28 Feb
'20
6:34 p.m.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39108 )
Change subject: vendorcode/intel/fsp/fsp2_0: Add FSP header files for Skylake-SP ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39108/1/src/vendorcode/intel/fsp/fs... File src/vendorcode/intel/fsp/fsp2_0/skylake_sp/hob_iiouds.h:
https://review.coreboot.org/c/coreboot/+/39108/1/src/vendorcode/intel/fsp/fs... PS1, Line 227:
Are these extra indents necessary?
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/39108
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If47f102c2c7979da1196f8c6b315d5be558e786c
Gerrit-Change-Number: 39108
Gerrit-PatchSet: 6
Gerrit-Owner: Jonathan Zhang jonzhang@fb.com
Gerrit-Reviewer: Andrey Petrov anpetrov@fb.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam anjaneya.chagam@intel.com
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Johnny Lin
Gerrit-Reviewer: Jonathan Zhang jonzhang@fb.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 28 Feb 2020 17:34:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment