Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36518 )
Change subject: trogdor: QCSDI loading depends on VB2_GBB_FLAG_FAFT_KEY_OVERIDE setting ......................................................................
Patch Set 21:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36518/21/src/soc/qualcomm/common/qc... File src/soc/qualcomm/common/qclib.c:
https://review.coreboot.org/c/coreboot/+/36518/21/src/soc/qualcomm/common/qc... PS21, Line 168: This should only have a single indent. You can align the above continuation line with the opening parenthesis of the if() instead to make the distinction clear.
https://review.coreboot.org/c/coreboot/+/36518/21/src/soc/qualcomm/common/qc... PS21, Line 227: qup_spi_init(QUPV3_1_SE0, 1010 * KHz); /* H1 SPI */ I know we still need this HACK until this can get fixed in QcLib (btw is someone tracking that?), but it doesn't belong in this patch.