Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37561 )
Change subject: drivers/intel/fsp2_0: Allow to add FSP binaries from repo for IceLake
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37561/7/src/drivers/intel/fsp2_0/Kc...
File src/drivers/intel/fsp2_0/Kconfig:
https://review.coreboot.org/c/coreboot/+/37561/7/src/drivers/intel/fsp2_0/Kc...
PS7, Line 58: SOC_INTEL_ICELAKE || SOC_INTEL_WHISKEYLAKE
At some point we should turn this into a opt-out before the […]
I am thinking of an additional option HAVE_INTEL_FSP_REPO which would be selected by the SoC and a dependency of FSP_USE_REPO.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37561
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I29faa8d3acff5680b611951fc193d33f514dc0d3
Gerrit-Change-Number: 37561
Gerrit-PatchSet: 7
Gerrit-Owner: Mimoja
coreboot@mimoja.de
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Christoph Pomaska
github@aufmachen.jetzt
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Mimoja
coreboot@mimoja.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-Comment-Date: Sat, 07 Dec 2019 20:53:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment