Vijay P Hiremath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38726 )
Change subject: ec/google/chromeec: Enable TCSS port set flag
......................................................................
Patch Set 15:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38726/15/src/soc/intel/tigerlake/ea...
File src/soc/intel/tigerlake/early_tcss.c:
https://review.coreboot.org/c/coreboot/+/38726/15/src/soc/intel/tigerlake/ea...
PS15, Line 140: }
port_state = PMC_IPC_TCSS_SAFE_MODE
https://review.coreboot.org/c/coreboot/+/38726/15/src/soc/intel/tigerlake/ea...
PS15, Line 142: if (mux_data.hpd_irq || mux_data.hpd_lvl)
: port_state = PMC_IPC_TCSS_HPD_MODE;
: else
: port_state = PMC_IPC_TCSS_ALTERNATE_MODE;
assign after line 147 is success.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38726
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idfc1e6515411fab75b7da1b60775c26d17089c1c
Gerrit-Change-Number: 38726
Gerrit-PatchSet: 15
Gerrit-Owner: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Vijay P Hiremath
vijay.p.hiremath@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Divya Sasidharan
divya.s.sasidharan@intel.corp-partner.google.com
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 11 Feb 2020 16:57:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment