Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46884 )
Change subject: drivers/intel/fsp2_0: Add function to report FSP-T output ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46884/1/src/soc/intel/common/block/... File src/soc/intel/common/block/cpu/car/cache_as_ram_fsp.S:
https://review.coreboot.org/c/coreboot/+/46884/1/src/soc/intel/common/block/... PS1, Line 75: push %ecx : push %edx
This is pushed on the stack instead of directly writing the variables as bss is cleared below. […]
a comment would be nice