Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32924 )
Change subject: soc/intel/common: Add negative sign check for variable bios_size
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
https://review.coreboot.org/#/c/32924/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32924/2//COMMIT_MSG@9
PS2, Line 9: Clang Static Analyzer version 8.0.0 found that the rounding operation
: of alignment=1UL<<(log2_ceil(bios_size)) is garbage or undefined if
: variable bios_size is negative
bios_size cannot be negative since it's type is unsigned. Clang static analyzer must be at fault here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32924
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifc3f3da52d129ef5d6063a46b045603a236be759
Gerrit-Change-Number: 32924
Gerrit-PatchSet: 2
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 23 May 2019 19:54:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment