Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38996 )
Change subject: mb/intel/jasperlake_rvp: Disable SATA controller
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38996/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38996/1//COMMIT_MSG@9
PS1, Line 9: This patch disables the SATA config from devicetree for JSL
Since we are not using the SATA controller.
You are not using the SATA controller on the reference board (RVP), that means there are no SATA connectors?
Please extend the commit message.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38996
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9cbcbf96e70b79bfb60f228b77a1065c26cd1aa2
Gerrit-Change-Number: 38996
Gerrit-PatchSet: 2
Gerrit-Owner: Usha P
usha.p@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 22 Feb 2020 21:28:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Usha P
usha.p@intel.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment