4 Mar
2020
4 Mar
'20
4:48 a.m.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39236 )
Change subject: mb/google/dedede: Enable trackpad support ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39236/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/39236/2/src/mainboard/google/dedede... PS2, Line 24: .rise_time_ns = 66, : .fall_time_ns = 90, : .data_hold_time_ns = 350 Can you please confirm with these configuration the measured speed was <= I2C_SPEED_FAST(400 KHz)
--
To view, visit https://review.coreboot.org/c/coreboot/+/39236
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I52c578aef591f5be90fb709bab4c8342ea9729e6
Gerrit-Change-Number: 39236
Gerrit-PatchSet: 2
Gerrit-Owner: Varshit B Pandya varshit.b.pandya@intel.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Justin TerAvest teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Aamir Bohra aamir.bohra@intel.com
Gerrit-Comment-Date: Wed, 04 Mar 2020 03:48:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment