You-Cheng Syu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30978 )
Change subject: google/kukui: Change TPM interface from SPI to I2C
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/30978/2/src/mainboard/google/kukui/verstage....
File src/mainboard/google/kukui/verstage.c:
https://review.coreboot.org/#/c/30978/2/src/mainboard/google/kukui/verstage....
PS2, Line 26: if (IS_ENABLED(CONFIG_BOARD_GOOGLE_KUKUI) && board_id() < 2) {
: die("This board is no longer supported. "
: "Please use older AP firmware.\n");
: }
I think during the transition we do want something to make it easier identifying if people has insta […]
Uploaded the checking part as a separate CL in http://crosreview.com/1466261
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30978
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I194de167aa946d592ba20cff15f076739e5cc096
Gerrit-Change-Number: 30978
Gerrit-PatchSet: 3
Gerrit-Owner: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@google.com
Gerrit-Reviewer: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: wang qii
Qii.Wang@mediatek.com
Gerrit-CC: Chun-ta Lin
itspeter@google.com
Gerrit-CC: Nicolas Boichat
drinkcat@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 12 Feb 2019 06:13:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nicolas Boichat
drinkcat@google.com
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment