Asami Doi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34774 )
Change subject: lib: ramdetect: Register exception handlers for ARMv8
......................................................................
Patch Set 5:
I said it's better to have all operations in one file in the previous comment, but it might not work well. Because "struct exc_state" is defined at an ARM specific header file, so other architectures can't build it.
I will use __weak function and divide 2 files to implement probe_mb() for other architectures if I can't find any solutions.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34774
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I09a306ca307ba4027d9758c3debc2e7c844c66b8
Gerrit-Change-Number: 34774
Gerrit-PatchSet: 5
Gerrit-Owner: Asami Doi
d0iasm.pub@gmail.com
Gerrit-Reviewer: Asami Doi
d0iasm.pub@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Wed, 21 Aug 2019 14:21:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment