Alexandru Gagniuc (mr.nuke.me@gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4585
-gerrit
commit 0b46e8d9e6e3816081057bba17ebb5cbe46ad223 Author: Alexandru Gagniuc mr.nuke.me@gmail.com Date: Sun Dec 29 18:13:58 2013 -0500
uart8250.h: Do not guard entire include file by config options
Do not guard the file by CONFIG_CONSOLE_SERIAL8250 or CONFIG_CONSOLE_SERIAL8250MEM. The config-specific options are already properly guarded, and there is no need to guard the register and bit definitions.
Change-Id: I7528b18cdc62bc5c22486f037e14002838a2176e Signed-off-by: Alexandru Gagniuc mr.nuke.me@gmail.com --- src/include/uart8250.h | 4 ---- 1 file changed, 4 deletions(-)
diff --git a/src/include/uart8250.h b/src/include/uart8250.h index bec3637..a3868c5 100644 --- a/src/include/uart8250.h +++ b/src/include/uart8250.h @@ -20,8 +20,6 @@ #ifndef UART8250_H #define UART8250_H
-#if CONFIG_CONSOLE_SERIAL8250 || CONFIG_CONSOLE_SERIAL8250MEM - /* Data */ #define UART_RBR 0x00 #define UART_TBR 0x00 @@ -141,6 +139,4 @@ void oxford_init(void); #endif #endif
-#endif /* CONFIG_CONSOLE_SERIAL8250 || CONFIG_CONSOLE_SERIAL8250MEM */ - #endif /* UART8250_H */