Hello build bot (Jenkins), Furquan Shaikh, Caveh Jalali, Kane Chen, Tim Wawrzynczak, Subrata Banik, Nick Vaccaro, Patrick Rudolph, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42677
to look at the new patch set (#5).
Change subject: soc/intel/tigerlake: Run pmc_set_acpi_mode() during .init in pmc_ops
......................................................................
soc/intel/tigerlake: Run pmc_set_acpi_mode() during .init in pmc_ops
pmc_set_acpi_mode() should run after Chrome EC deal with all host event
bits, like SMI mask (otherwise the FAFT firmware_FWScreenCloseLid test
will fail.)
BUG=b:153249055
TEST=FW_NAME=malefor emerge-volteer coreboot chromeos-bootimage
Change the GBB flag to 0x140 then check SMI mask during depthcharge
phase, make sure it's 0x0000000000000001.
Signed-off-by: William Wei wenxu.wei@bitland.corp-partner.google.com
Change-Id: Icfff5cc5550f23938343e4d26ef76093bb9cf7c3
---
M src/soc/intel/tigerlake/pmc.c
1 file changed, 23 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/42677/5
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42677
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icfff5cc5550f23938343e4d26ef76093bb9cf7c3
Gerrit-Change-Number: 42677
Gerrit-PatchSet: 5
Gerrit-Owner: William Wei
wenxu.wei@bitland.corp-partner.google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: William Wei
wenxu.wei@bitland.corp-partner.google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Magf -
magf@bitland.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Xiong Huang
xiong.huang@bitland.corp-partner.google.com
Gerrit-CC: Zhuohao Lee
zhuohao@google.com
Gerrit-MessageType: newpatchset