Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44302 )
Change subject: mb/lenovo/thinkcentre_m91p add ThinkCentre M91p ......................................................................
Patch Set 12:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44302/1/src/mainboard/lenovo/thinkc... File src/mainboard/lenovo/thinkcentre_m91p/early_init.c:
https://review.coreboot.org/c/coreboot/+/44302/1/src/mainboard/lenovo/thinkc... PS1, Line 33: /* FIXME: Put proper SPD map here. */
Easy way to test: check if the board is able to boot with a single DIMM, for every slot. […]
See latest patchset.
https://review.coreboot.org/c/coreboot/+/44302/12/src/mainboard/lenovo/think... File src/mainboard/lenovo/thinkcentre_m91p/early_init.c:
https://review.coreboot.org/c/coreboot/+/44302/12/src/mainboard/lenovo/think... PS12, Line 36: read_spd(&spd[1], 0x52, id_only); : read_spd(&spd[2], 0x51, id_only); The SPD addresses for these two are swapped, and should be:
read_spd(&spd[1], 0x51, id_only); read_spd(&spd[2], 0x52, id_only);
Easy way to test: check if the board is able to boot with a single DIMM, for every slot. Especially interesting are the two middle slots.