Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47980 )
Change subject: lp4x: Add new memory parts and generate SPDs
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47980/1/util/spd_tools/lp4x/global_...
File util/spd_tools/lp4x/global_lp4x_mem_parts.json.txt:
https://review.coreboot.org/c/coreboot/+/47980/1/util/spd_tools/lp4x/global_...
PS1, Line 221: {
Thanks, will fix it on next patch upload.
Done
https://review.coreboot.org/c/coreboot/+/47980/1/util/spd_tools/lp4x/global_...
PS1, Line 226: 1
From JEDEC spec JESD209-4C, Figure 1, for x16 part, if 2 sets of DQ[15:0] share the same ZQ pin, the […]
Thanks, Furquan !
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47980
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I09c6eab640c169dbdb451964967d14a31e314496
Gerrit-Change-Number: 47980
Gerrit-PatchSet: 2
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 25 Nov 2020 03:34:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment