Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37185 )
Change subject: nb/intel/sandybridge: Fix mrc.bin path
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37185/1/src/northbridge/intel/sandy...
File src/northbridge/intel/sandybridge/Kconfig:
https://review.coreboot.org/c/coreboot/+/37185/1/src/northbridge/intel/sandy...
PS1, Line 79: The amount of BSP stack anticipated in bootblock and
Is there a reason to not place this unde if !USE_NATIVE_RAMINIT ?
While not there yet, I'd like the CAR set up in bootblock to be compatible with either bootpaths in romstage. Most of of the 128K CAR ends up unused on the native codepath so this does not really matter.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37185
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic422980ca1a0549b6937e30a433ce52e0d7a595c
Gerrit-Change-Number: 37185
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Mon, 25 Nov 2019 08:08:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment