Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38736 )
Change subject: lib/imd_cbmem.c: Add a helper function to indicate that cbmem is ready ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38736/1/src/include/cbmem.h File src/include/cbmem.h:
https://review.coreboot.org/c/coreboot/+/38736/1/src/include/cbmem.h@85 PS1, Line 85: int cbmem_ready(void); I think you should add some commentary that the CBMEM_HOOKs won't necessarily see a consistent value here because of the current implementation. While it is implicit in the calling of the hooks themselves we should also note it here in case there's some shared code and people don't realize they might not see this reflected. If you do want always consistent assertion of this value then you shouldn't use the cbmem hooks to mark the variable in the positive.