Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34188 )
Change subject: mb/google/octopus/variants/garg: support LTE power sequence
......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34188/7/src/mainboard/google/octopu...
File src/mainboard/google/octopus/variants/baseboard/include/baseboard/gpio.h:
https://review.coreboot.org/c/coreboot/+/34188/7/src/mainboard/google/octopu...
PS7, Line 36: /* LTE reset GPIO */
: #define GPIO_LTE_RESET GPIO_161
:
Not required anymore.
https://review.coreboot.org/c/coreboot/+/34188/7/src/mainboard/google/octopu...
File src/mainboard/google/octopus/variants/garg/variant.c:
https://review.coreboot.org/c/coreboot/+/34188/7/src/mainboard/google/octopu...
PS7, Line 37: if (slp_typ != ACPI_S5)
: return;
nit: If you do this before calling get_board_sku(), one transaction to the EC can be saved in non-S5 cases.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34188
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7bf6fee087c885c22363b44aa98aa61f91be90b4
Gerrit-Change-Number: 34188
Gerrit-PatchSet: 7
Gerrit-Owner: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Kevin Chiu
kevin.chiu@quanta.corp-partner.google.com
Gerrit-Reviewer: Marco Chen
marcochen@chromium.org
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 11 Jul 2019 18:35:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment