Attention is currently required from: Furquan Shaikh, Sumeet R Pawnikar, Patrick Rudolph, Karthik Ramasubramanian. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57096 )
Change subject: tpch: Introduce new thermal control mechanism for pch device ......................................................................
Patch Set 3:
(5 comments)
Patchset:
PS3: Looking nice ! 😊
File src/drivers/intel/dptf/Kconfig:
https://review.coreboot.org/c/coreboot/+/57096/comment/882ab49f_b429693b PS3, Line 12: help also: `depends on PMC_IPC_ACPI_INTERFACE`
https://review.coreboot.org/c/coreboot/+/57096/comment/bbe38d0e_1c023534 PS3, Line 13: tpch dptf
File src/drivers/intel/dptf/dptf.c:
https://review.coreboot.org/c/coreboot/+/57096/comment/ff4bec90_33a39602 PS3, Line 212: acpigen_write_package(0); A 0-element package? how odd... but I think you still need to end the package too, i.e.: `acpigen_write_package_end();`
https://review.coreboot.org/c/coreboot/+/57096/comment/cdf563b1_92c2989f PS3, Line 220: { : acpigen_write_scope("\_SB"); : acpigen_write_device("TPCH"); Does the scope of this device matter? Can it just live under the DPTF device like all the others (except TCPU which cannot)? It looks like the kernel driver just matches on the `_HID` so I think it will work