Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47606 )
Change subject: nb/intel/sandybridge: Rename loop variable ......................................................................
nb/intel/sandybridge: Rename loop variable
What `discover_edges_real` is shmooing is the DQS PI setting.
Change-Id: I67390ba315d618d153f91c0e8a81db04ec8f63e1 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/sandybridge/raminit_common.c 1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/47606/1
diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c index 257eae4..e740f55 100644 --- a/src/northbridge/intel/sandybridge/raminit_common.c +++ b/src/northbridge/intel/sandybridge/raminit_common.c @@ -2345,14 +2345,14 @@
static int discover_edges_real(ramctr_timing *ctrl, int channel, int slotrank, int *edges) { - int edge; + int dqs_pi; int stats[NUM_LANES][MAX_EDGE_TIMING + 1]; int lane;
- for (edge = 0; edge <= MAX_EDGE_TIMING; edge++) { + for (dqs_pi = 0; dqs_pi <= MAX_EDGE_TIMING; dqs_pi++) { FOR_ALL_LANES { - ctrl->timings[channel][slotrank].lanes[lane].rising = edge; - ctrl->timings[channel][slotrank].lanes[lane].falling = edge; + ctrl->timings[channel][slotrank].lanes[lane].rising = dqs_pi; + ctrl->timings[channel][slotrank].lanes[lane].falling = dqs_pi; } program_timings(ctrl, channel);
@@ -2372,7 +2372,7 @@ wait_for_iosav(channel);
FOR_ALL_LANES { - stats[lane][edge] = MCHBAR32(IOSAV_By_ERROR_COUNT_ch(channel, lane)); + stats[lane][dqs_pi] = MCHBAR32(IOSAV_By_ERROR_COUNT_ch(channel, lane)); } }