Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/57347 )
Change subject: mb/intel/leafhill,minnow3: remove FSP_M_FILE and FSP_S_FILE override ......................................................................
mb/intel/leafhill,minnow3: remove FSP_M_FILE and FSP_S_FILE override
Normally, selecting FSP_USE_REPO will select FSP_FULL_FD which then will configure the proper paths for FSP_M_FILE and FSP_S_FILE. The override in these two boards caused FSP_M_FILE and FSP_S_FILE being empty despite ADD_FSP_BINARIES being selected by FSP_USE_REPO which is an invalid case that needs to be avoided, so remove the board-level override of those two options.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I20c8cebea8327d59f0f33d05b824a74bf2121f4b Reviewed-on: https://review.coreboot.org/c/coreboot/+/57347 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/mainboard/intel/leafhill/Kconfig M src/mainboard/intel/minnow3/Kconfig 2 files changed, 0 insertions(+), 20 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/mainboard/intel/leafhill/Kconfig b/src/mainboard/intel/leafhill/Kconfig index dc2eff6..bf59d00 100644 --- a/src/mainboard/intel/leafhill/Kconfig +++ b/src/mainboard/intel/leafhill/Kconfig @@ -44,16 +44,6 @@ depends on NEED_IFWI default y
-config FSP_M_FILE - string "path to FSP-M.Fv blob" - depends on ADD_FSP_BINARIES - default "" - -config FSP_S_FILE - string "path to FSP-S.Fv blob" - depends on ADD_FSP_BINARIES - default "" - config FSP_S_CBFS string default "fsps.bin" diff --git a/src/mainboard/intel/minnow3/Kconfig b/src/mainboard/intel/minnow3/Kconfig index 41aacdd..13a8591 100644 --- a/src/mainboard/intel/minnow3/Kconfig +++ b/src/mainboard/intel/minnow3/Kconfig @@ -44,16 +44,6 @@ depends on NEED_IFWI default y
-config FSP_M_FILE - string "path to FSP-M.Fv blob" - depends on ADD_FSP_BINARIES - default "" - -config FSP_S_FILE - string "path to FSP-S.Fv blob" - depends on ADD_FSP_BINARIES - default "" - config FSP_S_CBFS string default "fsps.bin"