10 Aug
2020
10 Aug
'20
2:13 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43942 )
Change subject: src/superio: Add missing '#include <stddef.h>' ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43942/1/src/superio/smsc/sch5545/sc... File src/superio/smsc/sch5545/sch5545_emi.h:
https://review.coreboot.org/c/coreboot/+/43942/1/src/superio/smsc/sch5545/sc... PS1, Line 6: #include <stddef.h>
types will include more than 6 headers. […]
I'd rather use a single #include <types.h> than have multiple included headers and the risk of inadvertently relying on indirect inclusion from other files.
--
To view, visit https://review.coreboot.org/c/coreboot/+/43942
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic6ffeb3881ee581c5e5b5d614dfd6efda2e5b2c2
Gerrit-Change-Number: 43942
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 10 Aug 2020 12:13:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes ehaouas@noos.fr
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment