build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44711 )
Change subject: soc/mediatek/mt8192: Add DDR mode register init ......................................................................
Patch Set 1:
(6 comments)
https://review.coreboot.org/c/coreboot/+/44711/1/src/soc/mediatek/mt8192/dra... File src/soc/mediatek/mt8192/dramc_dvfs.c:
https://review.coreboot.org/c/coreboot/+/44711/1/src/soc/mediatek/mt8192/dra... PS1, Line 40: if (pll_mode == PHYPLL_MODE) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/c/coreboot/+/44711/1/src/soc/mediatek/mt8192/dra... File src/soc/mediatek/mt8192/dramc_pi_basic_api.c:
https://review.coreboot.org/c/coreboot/+/44711/1/src/soc/mediatek/mt8192/dra... PS1, Line 3876: for (u8 chn = 0; chn < CHANNEL_MAX; chn++) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/44711/1/src/soc/mediatek/mt8192/dra... PS1, Line 3876: for (u8 chn = 0; chn < CHANNEL_MAX; chn++) please, no space before tabs
https://review.coreboot.org/c/coreboot/+/44711/1/src/soc/mediatek/mt8192/dra... PS1, Line 3876: for (u8 chn = 0; chn < CHANNEL_MAX; chn++) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/44711/1/src/soc/mediatek/mt8192/dra... PS1, Line 3965: if (cali->support_ranks == DUAL_RANK_DDR) suspect code indent for conditional statements (16, 20)
https://review.coreboot.org/c/coreboot/+/44711/1/src/soc/mediatek/mt8192/dra... PS1, Line 3967: else suspect code indent for conditional statements (16, 20)