David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34679 )
Change subject: soc/fsp_broadwell_de: Implement SMBus read/write over IMC
......................................................................
Patch Set 5: Code-Review-1
(1 comment)
One small nit, otherwise LGTM
https://review.coreboot.org/c/coreboot/+/34679/5/src/soc/intel/fsp_broadwell...
File src/soc/intel/fsp_broadwell_de/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/34679/5/src/soc/intel/fsp_broadwell...
PS5, Line 22: romstage-y += smbus-imc.c
Nit: Move this up a few lines, to where romstage-y sources are included.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34679
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9f5993dc795badf72751a4e6c9d974119a653e30
Gerrit-Change-Number: 34679
Gerrit-PatchSet: 5
Gerrit-Owner: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 10 Aug 2019 10:21:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment