Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39498 )
Change subject: src/soc/intel/tigerlake: Fix incorrect use of Field objects in ASL
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/39498/2/src/soc/intel/tigerlake/acp...
File src/soc/intel/tigerlake/acpi/camera_clock_ctl.asl:
https://review.coreboot.org/c/coreboot/+/39498/2/src/soc/intel/tigerlake/acp...
PS2, Line 26: Method (OFST, 0x1, NotSerialized)
description would help, OFST is for offset?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39498
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8b886255d5f38819502ae1f4af0851b5a0922b22
Gerrit-Change-Number: 39498
Gerrit-PatchSet: 3
Gerrit-Owner: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 13 Mar 2020 13:09:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment