Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39477 )
Change subject: mb/google/dedede: Enable Intel Speed Shift Technology
......................................................................
Patch Set 5:
Patch Set 5:
Patch Set 5:
(2 comments)
Patch Set 5:
Not to be too much of a stickler, but this is the whole reason for mainboard_silicon_init_params(FSP_S_CONFIG *params). It gives you a chance to update FSP_S UPDs before FSP-S runs. And if 'dee and 'doo are all the variants you have right now, you could just leave the check and setting of ISST in mainboard.c for now.
I think what Karthik identified was yyou
Karthik and I chatted about this, it was a misunderstanding on my part.
Woops.. I had typed that and removed it after you posted your latest comment, but somehow it didn't get removed completely.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39477
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id65d7981501c2f282e564bfc140f8d499d5713e8
Gerrit-Change-Number: 39477
Gerrit-PatchSet: 5
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 20 May 2020 18:58:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment