Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35463 )
Change subject: device/mmio.h: Add bit field helpers ......................................................................
Patch Set 12:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35463/11//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35463/11//COMMIT_MSG@48 PS11, Line 48: REAED32_BITFIELD(®, SEC_VIO)
READ32_BITFIELD
Done
https://review.coreboot.org/c/coreboot/+/35463/11/src/include/device/mmio.h File src/include/device/mmio.h:
https://review.coreboot.org/c/coreboot/+/35463/11/src/include/device/mmio.h@... PS11, Line 112: */
Should that also into the coding style documentation or something related, new developers can easily […]
we can do that later if we find these macro being really helpful, and have few existing programs migrated to using that.