[coreboot-gerrit] New patch to review for coreboot: 7f98671 w83627hf/acpi: Fix logical device power down in ACPI

[Christoph Grenz]

Christoph Grenz ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3605

-gerrit

commit 7f9867122e3dff8e814efa7dc0f7663371cf4e94
Author: Christoph Grenz 
Date:   Thu Jul 4 03:41:39 2013 +0200

w83627hf/acpi: Fix logical device power down in ACPI

As Nico noticed for the W83627DHG, the power management bits to power down
    individual logical devices on Winbond superios are named counterintuitively
    and need to be set when the logical device should be powered.

This corrects the power management methods for the W83627HF.

Change-Id: I98bccd550a0513c62bfa9480275f88c566691bc8
    Signed-off-by: Christoph Grenz 
---
 src/superio/winbond/w83627hf/acpi/superio.asl | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/src/superio/winbond/w83627hf/acpi/superio.asl b/src/superio/winbond/w83627hf/acpi/superio.asl
index 6dc08b9..cb1a262 100644
--- a/src/superio/winbond/w83627hf/acpi/superio.asl
+++ b/src/superio/winbond/w83627hf/acpi/superio.asl
@@ -241,13 +241,13 @@ Device(SIO) {
    	/* Disable power saving mode */
    	Method (_PS0) {
    		ENCM (0xFF)
-			Store (Zero, FDPW)
+			Store (One, FDPW)
    		EXCM ()
    	}
    	/* Enable power saving mode */
    	Method (_PS1) {
    		ENCM (0xFF)
-			Store (One, FDPW)
+			Store (Zero, FDPW)
    		EXCM ()
    	}

@@ -466,13 +466,13 @@ Device(SIO) {
    	}
    	Method (_PS1) {
    		ENCM (0xFF)
-			Store (One, PRPW)
+			Store (Zero, PRPW)
    		EXCM ()
    	}

Method (_DIS) {
    		ENCM (1)
-			Store (Zero, ACTR)
+			Store (One, ACTR)
    		EXCM ()
    	}

@@ -638,12 +638,12 @@ Device(SIO) {
    	}
    	Method (_PS0) {
    		ENCM (0xFF)
-			Store (Zero, UAPW)
+			Store (Ons, UAPW)
    		EXCM ()
    	}
    	Method (_PS1) {
    		ENCM (0xFF)
-			Store (One, UAPW)
+			Store (Zero, UAPW)
    		EXCM ()
    	}

@@ -763,12 +763,12 @@ Device(SIO) {
    	}
    	Method (_PS0) {
    		ENCM (0xFF)
-			Store (Zero, UBPW)
+			Store (One, UBPW)
    		EXCM ()
    	}
    	Method (_PS1) {
    		ENCM (0xFF)
-			Store (One, UBPW)
+			Store (Zero, UBPW)
    		EXCM ()
    	}

@@ -888,12 +888,12 @@ Device(SIO) {
    	}
    	Method (_PS0) {
    		ENCM (0xFF)
-			Store (Zero, UBPW)
+			Store (One, UBPW)
    		EXCM ()
    	}
    	Method (_PS1) {
    		ENCM (0xFF)
-			Store (One, UBPW)
+			Store (Zero, UBPW)
    		EXCM ()
    	}

@@ -1413,14 +1413,14 @@ Device(SIO) {
    	Method (_PS0)
    	{
    		ENCM (0xFF)
-			Store (Zero, HWPW)
+			Store (One, HWPW)
    		EXCM ()
    	}

Method (_PS1)
    	{
    		ENCM (0xFF)
-			Store (One, HWPW)
+			Store (Zero, HWPW)
    		EXCM ()
    	}