Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42073 )
Change subject: [WIP] sb,soc/amd: Allow dynamic ACPIMMIO base address ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42073/2/src/soc/amd/common/block/in... File src/soc/amd/common/block/include/amdblocks/acpimmio_map.h:
https://review.coreboot.org/c/coreboot/+/42073/2/src/soc/amd/common/block/in... PS2, Line 47: #else
Basically, the interface is that one has to request each bank individually: https://review.coreboot. […]
Ack
https://review.coreboot.org/c/coreboot/+/42073/2/src/soc/amd/common/block/in... PS2, Line 83: #define ACPIMMIO_BASE(base, x) (void *)(base + ACPIMMIO_ ## x ## _BANK)
Which ones were you referring to? The supported mappings for service call are not all the mmio bases […]
All the banks together would have been one 8 KB mapping. I'll just remove ACPIMMIO_BASE() with next rebase.
https://review.coreboot.org/c/coreboot/+/42073/1/src/soc/amd/common/block/ac...