Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38799 )
Change subject: soc/intel/common: Check prerequisites for HMRFPO_GET_STATUS command
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38799/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38799/1//COMMIT_MSG@9
PS1, Line 9: Add code to check prerequisites before sending HMRFPO_GET_STATUS comman
nit: I know that the information will be part of CSE BIOS spec, would be helpful to mention the prerequisites here or in the comment for the function.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38799
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4380e5096c6346d88aae6826d19a2f4ed1e97036
Gerrit-Change-Number: 38799
Gerrit-PatchSet: 1
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 10 Feb 2020 10:50:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment