[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Change in SaGv options

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30917 )

Change subject: soc/intel/cannonlake: Change in SaGv options
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/30917/2/src/soc/intel/cannonlake/chip.h 
File src/soc/intel/cannonlake/chip.h:

https://review.coreboot.org/#/c/30917/2/src/soc/intel/cannonlake/chip.h@109 
PS2, Line 109: 		SaGv_FixedMid,
this means that SaGv is passed different numbers depending on compile time options. Is that deliberate (ie. Are there different FSPs, is the FSP parsing these numbers differently depending on the SoC it runs on, or is the SoC interpreting the number differently depending on its type)?