Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41586 )
Change subject: drivers/vpd: rename VPD_ANY to VPD_RO_THEN_RW
......................................................................
Patch Set 4:
(2 comments)
Thanks!
https://review.coreboot.org/c/coreboot/+/41586/3/src/drivers/vpd/vpd.h
File src/drivers/vpd/vpd.h:
https://review.coreboot.org/c/coreboot/+/41586/3/src/drivers/vpd/vpd.h@18
PS3, Line 18: VPD_RO_OR_RW
I think I would prefer something like VPD_RO_THEN_RW to make more clear that it's intentionally orde […]
Done
https://review.coreboot.org/c/coreboot/+/41586/3/src/drivers/vpd/vpd.c
File src/drivers/vpd/vpd.c:
https://review.coreboot.org/c/coreboot/+/41586/3/src/drivers/vpd/vpd.c@179
PS3, Line 179: consumed = 0;
Sure, I will wait till Julius's patch was merged. I am not in hurry.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41586
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I960688d1f6ab199768107ab73b8a7400a3fdf473
Gerrit-Change-Number: 41586
Gerrit-PatchSet: 4
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 28 May 2020 23:25:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment