Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38210 )
Change subject: mb/google/hatch/variants/mushu: Configure gpio setting of dGPU power mode BOMACO
......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38210/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38210/3//COMMIT_MSG@7
PS3, Line 7: BOMACO
BOMSCO or BOMACO? What is that?
https://review.coreboot.org/c/coreboot/+/38210/3//COMMIT_MSG@7
PS3, Line 7: mb/google/hatch/variants/mushu: Configure gpio setting of dGPU power mode BOMACO
Better and shorter:
Enable dGPU power mode to …
https://review.coreboot.org/c/coreboot/+/38210/3//COMMIT_MSG@9
PS3, Line 9: ping
pin
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38210
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic35e55771d76b7254bcb457fcb38f37433b9ad67
Gerrit-Change-Number: 38210
Gerrit-PatchSet: 3
Gerrit-Owner: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-Reviewer: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: John Su
john_su@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 24 Jan 2020 15:41:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
