Change in coreboot[master]: mb/google/hatch: Configure gpio setting for dGPU power mode BOMACO
Amanda Hwang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38210 )
Change subject: mb/google/hatch: Configure gpio setting for dGPU power mode BOMACO ......................................................................
mb/google/hatch: Configure gpio setting for dGPU power mode BOMACO
Configure GPP_H22 as output ping for BOMSCO mode enabled.
Change-Id: Ic35e55771d76b7254bcb457fcb38f37433b9ad67 Signed-off-by: Amanda Huang amanda_hwang@compal.corp-partner.google.com --- M src/mainboard/google/hatch/variants/mushu/gpio.c 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/38210/1
diff --git a/src/mainboard/google/hatch/variants/mushu/gpio.c b/src/mainboard/google/hatch/variants/mushu/gpio.c index 09e1594..a60662a 100644 --- a/src/mainboard/google/hatch/variants/mushu/gpio.c +++ b/src/mainboard/google/hatch/variants/mushu/gpio.c @@ -41,6 +41,8 @@ PAD_CFG_GPO(GPP_C15, 1, DEEP), /* H3 : SPKR_PA_EN */ PAD_CFG_GPO(GPP_H3, 0, DEEP), + /* H22 : BOMACO_EN */ + PAD_CFG_GPO(GPP_H22, 0, DEEP), };
const struct pad_config *override_gpio_table(size_t *num)
Amanda Hwang has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/38210 )
Change subject: mb/google/hatch: Configure gpio setting of dGPU power mode BOMACO for Mushu ......................................................................
mb/google/hatch: Configure gpio setting of dGPU power mode BOMACO for Mushu
Configure GPP_H22 as output ping for BOMSCO mode enabled.
Change-Id: Ic35e55771d76b7254bcb457fcb38f37433b9ad67 Signed-off-by: Amanda Huang amanda_hwang@compal.corp-partner.google.com --- M src/mainboard/google/hatch/variants/mushu/gpio.c 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/38210/2
Amanda Hwang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38210 )
Change subject: mb/google/hatch: Configure gpio setting of dGPU power mode BOMACO for Mushu ......................................................................
Patch Set 2:
This change is ready for review.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38210 )
Change subject: mb/google/hatch: Configure gpio setting of dGPU power mode BOMACO for Mushu ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38210/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38210/2//COMMIT_MSG@7 PS2, Line 7: mb/google/hatch mb/google/hatch/variants/mushu
You can also remove the "for Mushu" from the title as this should make it clear.
EricR Lai has uploaded a new patch set (#3) to the change originally created by Amanda Hwang. ( https://review.coreboot.org/c/coreboot/+/38210 )
Change subject: mb/google/hatch/variants/mushu: Configure gpio setting of dGPU power mode BOMACO ......................................................................
mb/google/hatch/variants/mushu: Configure gpio setting of dGPU power mode BOMACO
Configure GPP_H22 as output ping for BOMSCO mode enabled.
Change-Id: Ic35e55771d76b7254bcb457fcb38f37433b9ad67 Signed-off-by: Amanda Huang amanda_hwang@compal.corp-partner.google.com --- M src/mainboard/google/hatch/variants/mushu/gpio.c 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/38210/3
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38210 )
Change subject: mb/google/hatch/variants/mushu: Configure gpio setting of dGPU power mode BOMACO ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38210/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38210/2//COMMIT_MSG@7 PS2, Line 7: mb/google/hatch
mb/google/hatch/variants/mushu […]
Done
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38210 )
Change subject: mb/google/hatch/variants/mushu: Configure gpio setting of dGPU power mode BOMACO ......................................................................
Patch Set 3: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38210 )
Change subject: mb/google/hatch/variants/mushu: Configure gpio setting of dGPU power mode BOMACO ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38210/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38210/3//COMMIT_MSG@7 PS3, Line 7: BOMACO BOMSCO or BOMACO? What is that?
https://review.coreboot.org/c/coreboot/+/38210/3//COMMIT_MSG@7 PS3, Line 7: mb/google/hatch/variants/mushu: Configure gpio setting of dGPU power mode BOMACO Better and shorter:
Enable dGPU power mode to …
https://review.coreboot.org/c/coreboot/+/38210/3//COMMIT_MSG@9 PS3, Line 9: ping pin
John Su has uploaded a new patch set (#4) to the change originally created by Amanda Hwang. ( https://review.coreboot.org/c/coreboot/+/38210 )
Change subject: mb/google/hatch/variants/mushu: Enable dGPU BOMACO mode ......................................................................
mb/google/hatch/variants/mushu: Enable dGPU BOMACO mode
Configure GPP_H22 as output pin for BOMACO mode enabled.
Change-Id: Ic35e55771d76b7254bcb457fcb38f37433b9ad67 Signed-off-by: Amanda Huang amanda_hwang@compal.corp-partner.google.com --- M src/mainboard/google/hatch/variants/mushu/gpio.c 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/38210/4
John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38210 )
Change subject: mb/google/hatch/variants/mushu: Enable dGPU BOMACO mode ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38210/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38210/3//COMMIT_MSG@7 PS3, Line 7: BOMACO
BOMSCO or BOMACO? What is that?
Done
https://review.coreboot.org/c/coreboot/+/38210/3//COMMIT_MSG@7 PS3, Line 7: mb/google/hatch/variants/mushu: Configure gpio setting of dGPU power mode BOMACO
Better and shorter: […]
Done
https://review.coreboot.org/c/coreboot/+/38210/3//COMMIT_MSG@9 PS3, Line 9: ping
pin
Done
Hello Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38210
to look at the new patch set (#5).
Change subject: mb/google/hatch/variants/mushu: Enable dGPU BOMACO mode ......................................................................
mb/google/hatch/variants/mushu: Enable dGPU BOMACO mode
Configure GPP_H22 as output pin for BOMACO mode enabled.
BUG=b:146081272 TEST=emerge-mushu coreboot
Change-Id: Ic35e55771d76b7254bcb457fcb38f37433b9ad67 Signed-off-by: Amanda Huang amanda_hwang@compal.corp-partner.google.com --- M src/mainboard/google/hatch/variants/mushu/gpio.c 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/38210/5
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38210 )
Change subject: mb/google/hatch/variants/mushu: Enable dGPU BOMACO mode ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38210/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38210/5//COMMIT_MSG@10 PS5, Line 10: What is BOMACO? Searching the WWW for it doesn’t tell me.
John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38210 )
Change subject: mb/google/hatch/variants/mushu: Enable dGPU BOMACO mode ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38210/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38210/5//COMMIT_MSG@10 PS5, Line 10:
What is BOMACO? Searching the WWW for it doesn’t tell me.
From GPU document,BOMACO is defined "Bus Off Memory Alive Core Off".
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38210 )
Change subject: mb/google/hatch/variants/mushu: Enable dGPU BOMACO mode ......................................................................
Patch Set 5: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/38210/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38210/5//COMMIT_MSG@10 PS5, Line 10:
From GPU document,BOMACO is defined "Bus Off Memory Alive Core Off".
I guess that's a power-saving mode where only the VRAM is powered. That would be the dGPU equivalent of ACPI S3 (the memory contents are preserved, but the rest of the system is powered off). Sounds pretty interesting, as it would provide good power savings at a reduced exit latency :-D
In any case, it would be nice to add this to the commit message:
BOMACO stands for "Bus Off Memory Alive Core Off".
John Su has uploaded a new patch set (#6) to the change originally created by Amanda Hwang. ( https://review.coreboot.org/c/coreboot/+/38210 )
Change subject: mb/google/hatch/variants/mushu: Enable dGPU BOMACO mode ......................................................................
mb/google/hatch/variants/mushu: Enable dGPU BOMACO mode
Configure GPP_H22 as output pin for BOMACO mode enabled. BOMACO stands for "Bus Off Memory Alive Core Off".
BUG=b:146081272 TEST=emerge-mushu coreboot
Change-Id: Ic35e55771d76b7254bcb457fcb38f37433b9ad67 Signed-off-by: Amanda Huang amanda_hwang@compal.corp-partner.google.com --- M src/mainboard/google/hatch/variants/mushu/gpio.c 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/38210/6
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38210 )
Change subject: mb/google/hatch/variants/mushu: Enable dGPU BOMACO mode ......................................................................
Patch Set 6:
(1 comment)
Thanks!
https://review.coreboot.org/c/coreboot/+/38210/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38210/5//COMMIT_MSG@10 PS5, Line 10:
I guess that's a power-saving mode where only the VRAM is powered. […]
Done
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38210 )
Change subject: mb/google/hatch/variants/mushu: Enable dGPU BOMACO mode ......................................................................
Patch Set 6: Code-Review+1
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38210 )
Change subject: mb/google/hatch/variants/mushu: Enable dGPU BOMACO mode ......................................................................
mb/google/hatch/variants/mushu: Enable dGPU BOMACO mode
Configure GPP_H22 as output pin for BOMACO mode enabled. BOMACO stands for "Bus Off Memory Alive Core Off".
BUG=b:146081272 TEST=emerge-mushu coreboot
Change-Id: Ic35e55771d76b7254bcb457fcb38f37433b9ad67 Signed-off-by: Amanda Huang amanda_hwang@compal.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38210 Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Shelley Chen shchen@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/variants/mushu/gpio.c 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Shelley Chen: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/mushu/gpio.c b/src/mainboard/google/hatch/variants/mushu/gpio.c index 09e1594..a60662a 100644 --- a/src/mainboard/google/hatch/variants/mushu/gpio.c +++ b/src/mainboard/google/hatch/variants/mushu/gpio.c @@ -41,6 +41,8 @@ PAD_CFG_GPO(GPP_C15, 1, DEEP), /* H3 : SPKR_PA_EN */ PAD_CFG_GPO(GPP_H3, 0, DEEP), + /* H22 : BOMACO_EN */ + PAD_CFG_GPO(GPP_H22, 0, DEEP), };
const struct pad_config *override_gpio_table(size_t *num)
-
Amanda Hwang (Code Review) -
Angel Pons (Code Review)
-
EricR Lai (Code Review)
-
John Su (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Shelley Chen (Code Review)