Attention is currently required from: Michael Niewöhner, HAOUAS Elyes.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46075 )
Change subject: mb/aopen: Convert to ASL 2.0 syntax
......................................................................
Patch Set 5:
(2 comments)
File src/mainboard/aopen/dxplplusu/acpi/i82801db.asl:
https://review.coreboot.org/c/coreboot/+/46075/comment/e25ec3db_48fd0630
PS5, Line 116: If (Local0 && 0x01)
Looks like original was wrong, bitwise and would make sense here. I'll rebase and push a fix.
https://review.coreboot.org/c/coreboot/+/46075/comment/a4cacacd_2eb8ff38
PS5, Line 131: If (Local0 && 0x01) {
as above
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46075
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib473121acfc0e985d4c0debecffdc1efbd9c3d66
Gerrit-Change-Number: 46075
Gerrit-PatchSet: 5
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Comment-Date: Wed, 10 Feb 2021 00:06:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment