[coreboot-gerrit] Change in coreboot[master]: mb/up/squared: rewrite GPIO config using intelp2m

[Maxim Polyakov (Code Review)]

Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39765 )

Change subject: mb/up/squared: rewrite GPIO config using intelp2m
......................................................................

Patch Set 6:

(1 comment)

Thanks for review

https://review.coreboot.org/c/coreboot/+/39765/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/39765/3//COMMIT_MSG@17 
PS3, Line 17: [WIP] Please review and test coreboot image with this patch
> But have you considered: […]

These *.rom files will be different since intelp2m generates some macros where PAD_CFG1_GPIO_DRIVER is used:

#define PAD_CFG_GPI_INT(pad, pull, rst, trig) \
    _PAD_CFG_STRUCT(pad,		\
    	PAD_FUNC(GPIO) | PAD_RESET(rst) | PAD_BUF(TX_DISABLE) |	\
    		PAD_CFG0_TRIG_##trig | PAD_CFG0_RX_POL_NONE,	\
    	PAD_PULL(pull) | PAD_CFG1_GPIO_DRIVER | PAD_IOSSTATE(TxDRxE))

However, in the version with raw dw0/1 values, PAD_CFG1_GPIO_DRIVER (0x1 << 4) isn't set.

How do you think PAD_CFG1_GPIO_DRIVER should be set if trig = OFF in the macro? PAD_CFG0_TRIG_OFF (2 << 25).

https://github.com/coreboot/coreboot/blob/master/src/soc/intel/common/block/...