[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso: Convert DDR4 MHz to MT/s correctly

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45177 )

Change subject: soc/amd/picasso: Convert DDR4 MHz to MT/s correctly
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45177/4/src/soc/amd/picasso/dmi.c 
File src/soc/amd/picasso/dmi.c:

https://review.coreboot.org/c/coreboot/+/45177/4/src/soc/amd/picasso/dmi.c@5... 
PS4, Line 58: static uint16_t _ddr4_speed_normalized_mts[] = {
> I'm confused why we don't just have an object that has 3 fields: […]

It does feel overly complicated.

+1 to both -- using an object with 3 fields to determine the reported_mts rather than doing all the calculations here and moving this to be a common library function since there is nothing picasso specific.