23 Sep
2020
23 Sep
'20
1:13 a.m.
John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45623 )
Change subject: ec/kontron: Fix control flow DEADCODE issue ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45623/4/src/ec/kontron/kempld/kempl... File src/ec/kontron/kempld/kempld_i2c.c:
https://review.coreboot.org/c/coreboot/+/45623/4/src/ec/kontron/kempld/kempl... PS4, Line 253: if (prescale < 0)
Sounds good. Regular `assert()` now provides compile-time checks if possible, too.
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/45623
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic002e708636961358969b2c1eaec0fee5bbcb73a
Gerrit-Change-Number: 45623
Gerrit-PatchSet: 5
Gerrit-Owner: John Zhao john.zhao@intel.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Maxim Polyakov max.senia.poliak@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 22 Sep 2020 23:13:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment