Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33797 )
Change subject: arch/riscv: Fix arch timer timebase
......................................................................
Patch Set 1:
Patch Set 1: Code-Review+1
I guess this is fine as a quick fix. Ideally, the timebase should be runtime detected, think MSRs of the x86 world, but simpler.
I couldn't find a CSR that reflects the clock frequency. It looks like that on fu540 it's an external clock driving mtime counter that board manufacturer should connect to 1MHz.
Do you have additional documentation how to do runtime detection?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33797
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2588149e2ee32130a2c41695c4c723b57d4fa827
Gerrit-Change-Number: 33797
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Xiang Wang
wxjstz@126.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Wed, 26 Jun 2019 14:51:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment