Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33737 )
Change subject: device/oprom: Add vbe return status support as per VBE spec 3.0 ......................................................................
Patch Set 9:
(4 comments)
https://review.coreboot.org/c/coreboot/+/33737/8/src/device/oprom/realmode/x... File src/device/oprom/realmode/x86.c:
https://review.coreboot.org/c/coreboot/+/33737/8/src/device/oprom/realmode/x... PS8, Line 246: mode = *video_mode_ptr++;
Thanks for the dump, I think I understand it now. I'm not concerned about […]
i will get back on this
https://review.coreboot.org/c/coreboot/+/33737/9/src/device/oprom/realmode/x... File src/device/oprom/realmode/x86_asm.S:
https://review.coreboot.org/c/coreboot/+/33737/9/src/device/oprom/realmode/x... PS9, Line 299: mov %eax, REALMODE_BASE
I don't understand this one: 1. When is the value restored? 2. Isn't […]
This is the return value from int 10, 0x4Fxx any function and value present in %al.
REALMODE_BASE is 0x600 which is application area in real mode. I can tell you the correct __realmode_idt address as well, its not 0x600. i need to see my log.
idea is to hold return value from function call into some memory adress which can exist between real/protected jump.
https://review.coreboot.org/c/coreboot/+/33737/9/src/include/vbe.h File src/include/vbe.h:
https://review.coreboot.org/c/coreboot/+/33737/9/src/include/vbe.h@47 PS9, Line 47: } __packed vbe_info_t;
You don't have to place it in a header file if it's going to be […]
thanks.
https://review.coreboot.org/c/coreboot/+/33737/9/src/include/vbe.h@59 PS9, Line 59: } vbe_info_t;
This is also only used in `yabel/vbe.c`. I think it would […]
thanks