Attention is currently required from: Raul Rangel, Stefan Reinauer, Julius Werner, Jacob Garber, Iru Cai.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40811 )
Change subject: arch,toolchain,xcompile: Use GCC as linker
......................................................................
Patch Set 9:
(2 comments)
Patchset:
PS9:
After rebasing I get with Debian’s toolchain (gcc (Debian 12.2.0-11) 12.2.0): […]
```
$ grep m32 build/xcompile
CLANG_CFLAGS_arm+=-Qunused-arguments -m32
GCC_CFLAGS_x86_32:= -Wno-address-of-packed-member --param=min-pagesize=1024 -m32 -Wl,-b,elf32-i386 -Wl,-melf_i386 -m32 -fuse-ld=bfd -fno-stack-protector -Wl,--build-id=none
GCC_ADAFLAGS_x86_32:=-m32 -Wl,-b,elf32-i386 -Wl,-melf_i386 -m32 -fuse-ld=bfd -fno-stack-protector -Wl,--build-id=none
CLANG_CFLAGS_x86_32:=-target i386-elf -m32 -Wl,-b,elf32-i386 -Wl,-melf_i386
CLANG_CFLAGS_x86_32+=-Qunused-arguments -m32
```
File src/arch/x86/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/40811/comment/8855f3bc_f2ba5d9c
PS9, Line 292: $(LD_ramstage) $(CPPFLAGS) $(LDFLAGS_ramstage) -o $@ -L$(obj) $< -T $(call src-to-obj,ramstage,$(CONFIG_MEMLAYOUT_LD_FILE))
Does this also need to be updated?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40811
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia551cf84c8f6eb3b010450fc572876a318a257d1
Gerrit-Change-Number: 40811
Gerrit-PatchSet: 9
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Iru Cai
mytbk920423@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Keith Hui
buurin@gmail.com
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Attention: Iru Cai
mytbk920423@gmail.com
Gerrit-Comment-Date: Sun, 08 Jan 2023 12:02:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment